Re: removing duplicate code

From: Robert Collins <robertc@dont-contact.us>
Date: 12 Oct 2002 19:21:57 +1000

On Sat, 2002-10-12 at 19:12, Henrik Nordstrom wrote:
> On Saturday 12 October 2002 01.57, Robert Collins wrote:
> > I'd like to drop this
> > http://www.squid-cache.org/~robertc/ufsduplicate.patch
> > into HEAD.
> >
> > Any objections, otherwise it goes in Tuesday.
>
> None from me at this time, but in the long run ufscommon should be a
> fs support library required by the "ufs" class FS:es, not a core
> component always included.

Yes,
IMO in the long run it should be as follows:
aufs, diskd go away.
ufs gets the ufscommon code again.

The aufs and diskd and ufs disk access logic become diskio modules, not
cache_dir modules. Then the ufs store takes a parameter - which diskio
module to use.

This removal of duplicates is a step in making the long term transition
easier and lower risk.

Rob

Received on Sat Oct 12 2002 - 03:22:01 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:16:55 MST