Re: [Bug 2541] Never ending loop while processing external acls using %{header: <delim>member} other than comma

The value in our original patch was to ensure that the key invariant of the loop--termination--was guaranteed. Of course, we sent this patch for what was (at our site) a critical bug in, what, February? That's 6 months from submitted fix, to fix thrown out and (apparently) still nothing committed.

Matt

----- bugzilla-daemon_at_squid-cache.org wrote:

> http://www.squid-cache.org/bugs/show_bug.cgi?id=2541
>
>
>
>
>
> --- Comment #5 from Henrik Nordstrom <hno_at_squid-cache.org> 2009-08-20
> 05:28:37 ---
> The bug is that , is meant to always be considered as a delimiter even
> if the
> arguments says otherwise (from HTTP header requirements), but the loop
> fails to
> handle this and only looks for the specified delimiter.
>
> Neither patch is correct.
>
> The simplest change is to add || **pos == ',' in the if statement
> looking for
> the delimiter but I'll rewrite it for clarity.
>
>
> --
> Configure bugmail:
> http://www.squid-cache.org/bugs/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You reported the bug.

-- 
Matt Benjamin
The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104
http://linuxbox.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309