Re: [Fwd: Pool for Request structur]

Rodney Holm wrote:

> I am not sure if this will happen in squid 2.1, as I do not have
> one running.

Squid 2.X does NOT behave in this way, that is for sure.

I ran a quick test on 1.1.22 and it does indeed leak request structures
on each proxy_auth request without a valid password.

The fix is probably like this:

        icpSendERROR(fd, icpState->log_type, wbuf, icpState,
icpState->http_code);
        /* Fix for leaking request structures */
        requestUnlink(icpState->aclChecklist->request);
        icpState->aclHandler = NULL;
        /* End fix */
        safe_free(icpState->aclChecklist);
        return;
    }
#endif /* USE_PROXY_AUTH */

--
Henrik Nordstrom
Spare time Squid hacker